Add workflow to Trigger build on PR add LGTM and Create Tag and Release with Changelog and push image to quay #366
Conversation
…se with Changelog and push image to quay
|
@Jooho @israel-hdez @spolti I am unsure of the quay credential varibles as i have no access to check the secret variables i have reffered this workflow and have added kserve-controller-docker-publish.yml. Please let me know if they are wrong |
| if: ${{ needs.wait-checks.result == 'success' }} | ||
| run: | | ||
| gh pr comment ${{ needs.create-pr.outputs.pr_number }} --body "/lgtm" | ||
| gh pr edit ${{ needs.create-pr.outputs.pr_number }} --add-label lgtm |
There was a problem hiding this comment.
the label is added anyways if someone comments /lgtm
There was a problem hiding this comment.
The label is indeed added if someone comments with /lgtm. However, our plan, based on prior discussions, was to automate this process to ensure consistency and efficiency.That said, it's not an issue to exclude it if necessary
| echo "has_lgtm=${has_lgtm}" >> $GITHUB_OUTPUT | ||
| break | ||
| has_lgtm=true | ||
| echo "has_lgtm=${has_lgtm}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
"has_lgtm" variable isn't currently utilized in the workflow. During testing it on local, I experimented with incorporating it for the merge part of the code.I can remove it.
| @@ -122,92 +121,92 @@ jobs: | |||
| if: ${{ needs.wait-checks.result == 'success' }} | |||
| run: | | |||
| gh pr comment ${{ needs.create-pr.outputs.pr_number }} --body "/lgtm" | |||
There was a problem hiding this comment.
Do we want to do it automatically without reviewing?
There was a problem hiding this comment.
is this create-pr coming from another workflow?
There was a problem hiding this comment.
Not exactly. While we could exclude it from automation, the initial plan was to incorporate it automatically.
| for i in {1..60}; do | ||
| with: | ||
| timeout_minutes: 120 | ||
| max_attempts: 60 |
There was a problem hiding this comment.
I guess GHA actions can be triggered based on events, this will be safer than a retry loop, wdyt?
There was a problem hiding this comment.
Yes we dont need wait-lgtm i had added this bit of code while testing on the Local will remove and push the code
|
/retest |
|
/retest-required |
| with: | ||
| registry: quay.io | ||
| username: ${{ secrets.QUAY_USERNAME }} | ||
| password: ${{ secrets.Q_PASSWORD }} |
There was a problem hiding this comment.
Yeah i have changed it even i am not sure of the variable name as i have no access to review the settings in the repo so i have reffered this fileLINK
There was a problem hiding this comment.
In the configs, I see it is QUAY_USER and QUAY_PASSWORD.
So, you may want to change it to QUAY_USER, rather than QUAY_USERNAME.
I do not have access to the values, so I'm not sure if it can be renamed... Although, I should have the credentials stored somewhere... So, we may merge as it is and I can later setup the new variable name.
There was a problem hiding this comment.
@rpancham Let me know if you will rename QUAY_USERNAME or if we merge as is.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, rpancham The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit 9a16be4
into
opendatahub-io:master
Add workflow to Trigger build on PR add LGTM and Create Tag and Release with Changelog and push image to quay
Add workflow to Trigger build on PR add LGTM and Create Tag and Release with Changelog and push image to quay
Add workflow to Trigger build on PR add LGTM and Create Tag and Release with Changelog and push image to quay
Add workflow to Trigger build on PR add LGTM and Create Tag and Release with Changelog and push image to quay
Add workflow to Trigger build on PR add LGTM and Create Tag and Release with Changelog and push image to quay
What this PR does / why we need it:
Automation PR builds/image for Kserve Repo
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #RHOAIENG-7438