Make STAC -> ODC conversion more robust to missing extension data #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If asset has no `.owner` then we can't tell if proj extension is enabled, so assume it isn't and skip proj check when determining if band is a data band or not.
Group bands by GSD with an assumption that bands with the same ground sampling distance share footprint and resolution
cfg parameter is meant to be optional
Codecov Report
@@ Coverage Diff @@
## develop #351 +/- ##
===========================================
+ Coverage 57.68% 58.06% +0.38%
===========================================
Files 75 75
Lines 6466 6525 +59
===========================================
+ Hits 3730 3789 +59
Misses 2736 2736
Continue to review full report at Codecov.
|
gadomski
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Collection -> Product
Collectionthat includes "Item Assets" extension then you can create Datacube product from that.dtype,nodatawill be read from thatSupport for STAC Items without Projection extension
For more information see #297, essentially if there is no projection extension found on an item, then we create Dataset object with "faked" grid, Dataset's
.extentis still valid and so data can be loaded from that Dataset, one just can't know what native resolution and projections are. But so long as user supplies desired resolution and projection for loaded data it's not a problem.