Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge cloud libs into one package (#331) #343

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Conversation

Kirill888
Copy link
Member

Combine odc.{aws,aio,azure,thredds} into one odc-cloud package.

  • odc-aws is now odc-cloud
  • odc-aio is now odc-cloud[ASYNC]
  • odc-thredds is now odc-cloud[THREDDS]
  • odc-azure is now odc-cloud[AZURE]

See #331 for discussions of reasons behind this change.

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #343 (b331d3d) into develop (21c5312) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #343      +/-   ##
===========================================
- Coverage    57.76%   57.74%   -0.03%     
===========================================
  Files           77       74       -3     
  Lines         6237     6234       -3     
===========================================
- Hits          3603     3600       -3     
  Misses        2634     2634              
Impacted Files Coverage Δ
libs/cloud/odc/aws/_find.py 97.43% <ø> (ø)
libs/cloud/odc/aws/queue.py 89.70% <ø> (ø)
libs/cloud/odc/cloud/_version.py 100.00% <ø> (ø)
libs/cloud/odc/ppt/__init__.py 50.00% <ø> (ø)
libs/cloud/odc/ppt/async_thread.py 100.00% <ø> (ø)
libs/cloud/odc/aio/__init__.py 59.58% <100.00%> (ø)
libs/cloud/odc/aws/__init__.py 21.57% <100.00%> (ø)
libs/cloud/odc/azure/__init__.py 100.00% <100.00%> (ø)
libs/cloud/odc/thredds/__init__.py 82.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21c5312...b331d3d. Read the comment docs.

@Kirill888 Kirill888 merged commit b67c2f5 into develop Aug 27, 2021
@Kirill888 Kirill888 deleted the merge-cloud-libs branch August 27, 2021 07:17
@Kirill888
Copy link
Member Author

sorry for merging without review, but I think we discussed it enough in an issue and I want to push those things to pypi today

@alexgleith
Copy link
Contributor

No worries :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants