license header update 2024 #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the reason the build fails on license check on scala 2.12, though? 🤔 |
|
Oh... it seems to complain that the grammar xml files do not have a license header. |
|
Yes, that's it. The /grammar/*.xml files miss the license header update. You will want to update these five file, too. Presumably needs to be done by hand. If the build is green, feel free to click the merge button. 🙂 |
|
Oops yeah, I was rebasing my Scala 3 PR to see if the plugin update helped (it doesn't) and then hit this, so I was skipping the build for those parts since they don't work with Java 17. Should be okay now 🫰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.