Chaining of non arithmetic operators #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvub
changed the title
hvub
force-pushed
the
chaining-of-non-arithmatic-operators
branch
2 times, most recently
from
6da0d76 to
475f73c
Compare
nadja-muller
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
It looks like this solves the problem described in the issue to me 👍
As a sidenote, comparing it with Cypher (Postfix1 in the code), I think there are some differences:
- We additionally allow listSlices, e.g. 1..2 in the same hierarchy as listOperatorExpression and PropertyLookups. I assume this is part of openCypher.
- We allow node & relationship expressions instead of only NodeLabels.
|
Just ran into the issue that |
hvub
force-pushed
the
chaining-of-non-arithmatic-operators
branch
from
475f73c to
14fc067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #541.
This PR proposes changes to the openCypher grammar for allowing chaining of non-arithmetic operators as a reaction to issue #539. With the PR, the grammar allows for instance
as valid syntax, which was not the case before.
The PR also adjusts CIP2021-08-10 Operator precedence (rendered view) to the changed grammar.