Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: only forward the questionnaire resource #8521

Merged
merged 2 commits into from
Jan 30, 2025
Merged

perf: only forward the questionnaire resource #8521

merged 2 commits into from
Jan 30, 2025

Conversation

Zangetsu101
Copy link
Collaborator

The other resources need not be forwarded as we are only updating the questionnaire resource.

@Zangetsu101
perf: only forward the questionnaire resource
fd92b91 
The other resources need not be forwarded as we are only
updating the questionnaire resource.
@Zangetsu101 Zangetsu101 requested a review from naftis January 29, 2025 13:31
@github-actions GitHub Actions
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

naftis
naftis approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@naftis naftis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Good catch. LGTM.

@naftis naftis added the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Jan 29, 2025
@naftis naftis temporarily deployed to improve-update-field January 29, 2025 13:52 — with GitHub Actions Inactive
@github-actions github-actions bot deployed to improve-update-field January 29, 2025 13:52 Active
@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://improve-update-field.opencrvs.dev

@Zangetsu101 Zangetsu101 merged commit c4deca1 into develop Jan 30, 2025
95 of 96 checks passed
@Zangetsu101 Zangetsu101 deleted the improve-update-field branch January 30, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naftis naftis naftis approved these changes

Assignees
No one assigned
Labels
🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zangetsu101 @ocrvs-bot @naftis