Events v2 collect certificate workflow boilerplate code #8321
+1,343
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
tareq89
force-pushed
the
ocrvs-event-v2-7919
branch
from
ab0e65e to
5bce870
Compare
rikukissa
reviewed
Jan 15, 2025
packages/events/src/router/router.ts
Outdated
Comment on lines
80
to
96
| appConfig: router({ | ||
| get: publicProcedure | ||
| .output(ApplicationConfigResponseSchema) | ||
| .query(async (options) => { | ||
| return getAppConfigurations(options.ctx.token) | ||
| }), | ||
| getCertificateTemplateSVGById: publicProcedure | ||
| .input(z.object({ id: z.string() })) | ||
| .output(z.string()) | ||
| .query(async (options) => { | ||
| const template = await getCertificateTemplateById( | ||
| options.ctx.token, | ||
| options.input.id | ||
| ) | ||
| return template | ||
| }) | ||
| }), |
There was a problem hiding this comment.
I think unless there's a compelling reason to do so, let's not bring these concerns into the events service. From memory, these should be available in the client's Redux store already? It's fine to read the Redux store from the new side if the information already exists there.
rikukissa
requested changes
Jan 15, 2025
tareq89
force-pushed
the
ocrvs-event-v2-7919
branch
from
5bce870 to
8566d57
Compare
makelicious
reviewed
Jan 15, 2025
packages/client/src/v2-events/components/forms/FormFieldGenerator.tsx
Outdated
Show resolved
Hide resolved
packages/client/src/v2-events/features/events/actions/collect-certificate/Review.tsx
Outdated
Show resolved
Hide resolved
packages/client/src/v2-events/features/events/actions/collect-certificate/Review.tsx
Outdated
Show resolved
Hide resolved
packages/client/src/v2-events/features/events/actions/collect-certificate/Review.tsx
Outdated
Show resolved
Hide resolved
packages/client/src/v2-events/features/events/actions/collect-certificate/Review.tsx
Outdated
Show resolved
Hide resolved
packages/client/src/v2-events/features/events/actions/collect-certificate/Review.tsx
Show resolved
Hide resolved
| eventId: event.id, | ||
| data: form, | ||
| transactionId: uuid(), | ||
| draft: true |
| @@ -0,0 +1,295 @@ | |||
| /* | |||
There was a problem hiding this comment.
Since events creates generic events, we might want to move some of the code out of client
There was a problem hiding this comment.
Yes, figuring out how to avoid them.
tareq89
force-pushed
the
ocrvs-event-v2-7919
branch
from
8566d57 to
35f3822
Compare
tareq89
force-pushed
the
ocrvs-event-v2-7919
branch
from
35f3822 to
29ac67d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7919