Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(User Roles) Remove legacy scopes #7792

Open
wants to merge 19 commits into
base: configurable-roles
Choose a base branch
from
Open

(User Roles) Remove legacy scopes #7792

wants to merge 19 commits into from

Conversation

Nil20
Copy link
Collaborator

@Nil20 Nil20 commented Oct 17, 2024 •
edited
Loading

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
Zangetsu101
Zangetsu101 requested changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@Zangetsu101 Zangetsu101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Barry has created this Scopes constant: https://github.com/opencrvs/opencrvs-core/blob/configurable-roles/packages/commons/src/scopes.ts#L12
Let's use this instead

@Nil20 Nil20 force-pushed the remove-legacy-scopes branch 2 times, most recently from d745128 to fbc2abe Compare October 28, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zangetsu101 Zangetsu101 Awaiting requested review from Zangetsu101

Assignees
No one assigned
Labels
🚧 work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nil20 @Zangetsu101