(User roles) Create useNavigation hook and extract scopes to constants #7741
Conversation
Strings are vulnerable to typos so constants are safer
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
tumbledwyer
force-pushed
the
scoped-components
branch
from
f5ce962
to
fa5cd7a
Compare
tumbledwyer
force-pushed
the
scoped-components
branch
from
6ca9679
to
29a8563
Compare
Used scope constants in authorization
| @@ -672,7 +600,7 @@ const NavigationView = (props: IFullProps) => { | |||
| } | |||
| /> | |||
| )} | |||
| {hasPerformance && userDetails && ( | |||
| {userDetails && hasAccess(WORKQUEUE_TABS.report) && ( | |||
There was a problem hiding this comment.
Performance tab is shown twice in the navigation
There was a problem hiding this comment.
This is in the original PR too, i think.
There was a problem hiding this comment.
Yeah, even on develop there are 2 navigation items that point to performance. The 2nd one just has an id of report and a different icon but both call the props.goToPerformanceViewAction
| @@ -89,6 +89,87 @@ export const scopes = [ | |||
| ] as const | |||
There was a problem hiding this comment.
@Zangetsu101 Shouldn't we remove constants from /client/src/utils/gateway.ts since this is a file that is auto generated? Otherwise, the auto generation would be hampered more.
There was a problem hiding this comment.
This is still being auto generated no? 😅
tumbledwyer
changed the title
tumbledwyer
changed the title
Create
useNavigationhook to extract scope logic away from the Navigation component.Changed scope list to constants in the commons package so they can be referenced anywhere in the app by name rather than a magic string.
fixed issue: #7433