Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v1.7.0): Modify location builder so it does not edit health facilities #7671

Merged

Conversation

tumbledwyer
Copy link
Collaborator

Cause of issue:

When a correction to a birth or death record was made from HEALTH_FACILITY to another type, instead of creating a new location, the original facility resource was edited.
This changed the type to PRIVATE_HOME or OTHER so when the facility dropdown is populated, the value is filtered out as it is no longer a HEALTH_FACILITY.

fixes: #7528

Health facilities were being edited as private homes on corrections which should not be allowed as there are static
@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://ocrvs-7528-fix-facility-disappearin.opencrvs.dev.

Copy link
Collaborator

@Zangetsu101 Zangetsu101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job figuring out this obscure bug!

@@ -445,3 +452,125 @@ describe('taskBundleWithExtension()', () => {
)
})
})

describe('updateFhirBundle', () => {
describe('when the type of a location is changed from HEALTH_FACILITY to another type', () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@tumbledwyer tumbledwyer changed the title Modify location builder so it does not edit health facilities fix(v1.7.0): Modify location builder so it does not edit health facilities Sep 27, 2024
@tumbledwyer tumbledwyer merged commit ec410b3 into develop Sep 30, 2024
35 of 39 checks passed
@tumbledwyer tumbledwyer deleted the ocrvs-7528-fix-facility-disappearing-from-dropdowns branch September 30, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants