Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍒 Merge changes from PR #7574 to release-v1.6.0 #7667

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

ocrvs-bot
Copy link
Collaborator

Automated PR to merge changes from develop to release-v1.6.0

I failed to cherry-pick the changes automatically because of the following:

usage: git cherry-pick [--edit] [-n] [-m <parent-number>] [-s] [-x] [--ff]
                     [-S[<keyid>]] <commit>...
 or: git cherry-pick (--continue | --skip | --abort | --quit)

  --quit                end revert or cherry-pick sequence
  --continue            resume revert or cherry-pick sequence
  --abort               cancel revert or cherry-pick sequence
  --skip                skip current commit and continue
  --[no-]cleanup <mode> how to strip spaces and #comments from message
  -n, --no-commit       don't automatically commit
  --commit              opposite of --no-commit
  -e, --[no-]edit       edit the commit message
  -s, --[no-]signoff    add a Signed-off-by trailer
  -m, --[no-]mainline <parent-number>
                        select mainline parent
  --[no-]rerere-autoupdate
                        update the index with reused conflict resolution if possible
  --[no-]strategy <strategy>
                        merge strategy
  -X, --[no-]strategy-option <option>
                        option for merge strategy
  -S, --[no-]gpg-sign[=<key-id>]
                        GPG sign commit
  -x                    append commit name
  --[no-]ff             allow fast-forward
  --[no-]allow-empty    preserve initially empty commits
  --[no-]allow-empty-message
                        allow commits with empty messages
  --[no-]keep-redundant-commits
                        deprecated: use --empty=keep instead
  --empty (stop|drop|keep)
                        how to handle commits that become empty

To continue manually you can use these commands:

git fetch origin auto-pr-release-v1.6.0-7574-5118:auto-pr-release-v1.6.0-7574-5118
git fetch origin ocrvs-7489-http-button:ocrvs-7489-http-button

git checkout auto-pr-release-v1.6.0-7574-5118
git reset --hard HEAD~1  # Remove placeholder commit
git cherry-pick 

tahmidrahman-dsi and others added 2 commits September 26, 2024 13:45
* chore(wip): introduce three new types of form field inputs

* chore(wip): create handler for button from form definitions

* fix: misc fixes

* refactor: move button logic into separate module and make a new field component

* fix: value update bug

* chore: add disable feature in button with misc improvements

* chore: add form validation for button fields missing trigger

* chore: update button component as per validation

* feat: eval request body and auth header from redux data

- with minor improvements

* feat: implement redirect for type `REDIRECT_BUTTON`

* chore: feedback amends

* Revert "feat: implement redirect for type `REDIRECT_BUTTON`"

This reverts commit 92ab385.

* chore: create a separate `useHttp` hook make http call from field

* fix: amend validation with minimal changes

* chore: add stricter types of fields in config form validation

* chore: set auth header using current user logged in token

* chore: configure proxy for countryconfig api route

* feat: buttonLabel and icon props for ButtonFormField

* chore: update field validation for button

* refactor: rename redirect button to only redirect

* chore: implement minimalistic redirect field

* chore: safe delete old proxy configs

* chore: minor amend api route in proxy config

* chore: handle loading state and organize code a bit

* fix: amend all places of usages of required parameters `draft` and `config` of expression evaluation methods

* chore: show validation error upon failed http request

* chore: amend validating logic so that a disabled button can show errors

* use an environment variable for country config url in nginx config instead of hard-coded values

* chore: update setValuesWithDependency so that it handles updates more than 1 level

- validate circular dependency

* chore: use only `setValueWithDependency` for setting field value imperatively

* refactor: amend code in request state handling

* fix: feedback amend

* fix: countryconfig env var name

* fix: countryconfig url in login app

* chore: add env variable in docker-compose file for login app

* chore: update nginx deploy config

* use proxy path also in generated html

* fix url rewrite

* fix login nginx file path

* fix wrong url path in client html

* remove /api/ prefix completely from country config redirects

* fix: minor amend to allow server send custom error message

---------

Co-authored-by: Riku Rouvila <[email protected]>
@makelicious makelicious merged commit 3ade5b1 into release-v1.6.0 Sep 27, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants