-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(env-vars): auth environment validation #7621
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
naftis
commented
Sep 17, 2024
rikukissa
reviewed
Sep 17, 2024
this is similar how it works in prod - think it's good to have them set explicit
rikukissa
reviewed
Sep 18, 2024
naftis
changed the title
refactor(env-vars): auth
refactor(env-vars): auth environment validation
Sep 18, 2024
rikukissa
reviewed
Sep 26, 2024
they are rarely being re-configured while this allows for that. Co-authored-by: Riku Rouvila <[email protected]>
Your environment is deployed to https://ocrvs-5932-auth.opencrvs.dev. |
rikukissa
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5932
Refactors auth to use envalid and enforce setting environment variables in production.