Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update allowing file type condition for signature #7601

Merged
merged 3 commits into from
Sep 12, 2024
Merged

fix: update allowing file type condition for signature #7601

merged 3 commits into from
Sep 12, 2024

Conversation

Nil20
Copy link
Collaborator

@Nil20 Nil20 commented Sep 10, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@Nil20 Nil20 changed the title fix: update allowing file types condition for signature fix: update allowing file type condition for signature Sep 10, 2024
@naftis naftis self-requested a review September 10, 2024 11:55
@naftis naftis added this to the v1.6.0 milestone Sep 10, 2024
@Nil20 Nil20 merged commit 36f0128 into develop Sep 12, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naftis naftis naftis approved these changes

Assignees
No one assigned
Labels
👌 LGTM ✅ Ready for merging
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Nil20 @naftis