fix: add the missing location details to a newly created declaration which was causing advanced search to break #7551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
rikukissa
approved these changes
Aug 30, 2024
Zangetsu101
approved these changes
Aug 30, 2024
Siyasanga
force-pushed
the
ocrvs-7494
branch
from
6d76930
to
b1f28b5
Compare
Siyasanga
force-pushed
the
ocrvs-7494
branch
from
b1f28b5
to
284d062
Compare
|
@Zangetsu101 I've added a condition to check if a location resource exists in the bundle before trying to fetch and that solved the failing test. Can you review it again please |
Siyasanga
pushed a commit
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event location information was missing in the bundle that gets sent to ElasticSearch fot newly created declarations, this caused Advanced Search not to work when searching by event location
#7494