fix a Sirupsen/logrus import issue in CI #527
Conversation
|
that wasn't it, trying something else... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #527 +/- ##
===========================================
+ Coverage 45.71% 73.48% +27.77%
===========================================
Files 57 60 +3
Lines 4843 4888 +45
===========================================
+ Hits 2214 3592 +1378
+ Misses 2363 937 -1426
- Partials 266 359 +93 |
|
@cyphar i'm not sure if zypper has a "don't include prereleases" option, that's probably better than just hard coding 1.21, since we'll have to keep bumping it forever... |
|
The reason is that our packaging in openSUSE has (had?) a bug where trying to install just "go" didn't give you the latest version. It should've been fixed, but since I handed off the Go packaging to a different guy at SUSE a few years ago it's been harder to get answers to these kinds of questions (I used to do Go packaging for (open)SUSE). We can try to remove and see what happens... |
| @@ -32,7 +32,7 @@ RUN zypper -n in \ | |||
| curl \ | |||
| git \ | |||
| gnu_parallel \ | |||
| "go>=1.18" \ | |||
| "go==1.21" \ | |||
There was a problem hiding this comment.
yup, that's the goal of the patch. otherwise we end up installing golang 1.22 which complains about the capitalization.
There was a problem hiding this comment.
Oh, that's the issue? That is very weird. I'll need to look into it...
we are seeing: 2.947 go: github.com/opencontainers/image-tools/cmd/oci-image-tool imports 2.947 github.com/Sirupsen/logrus: github.com/Sirupsen/[email protected]: parsing go.mod: 2.947 module declares its path as: github.com/sirupsen/logrus 2.947 but was required as: github.com/Sirupsen/logrus in CI, but that's (maybe) because of: opencontainers#8 22.11 Retrieving: go1.22-1.22rc1-lp155.7.1.x86_64 (obs-go) (67/68), 34.9 MiB opencontainers#8 22.11 Retrieving: go1.22-1.22rc1-lp155.7.1.x86_64.rpm [....................done (18.3 MiB/s)] opencontainers#8 24.27 Retrieving: go-1.22-lp155.1.1.x86_64 (obs-go) (68/68), 35.4 KiB opencontainers#8 24.27 Retrieving: go-1.22-lp155.1.1.x86_64.rpm [.....done (53.7 KiB/s)] go 1.22 is not yet released, so perhaps it's a regression? Signed-off-by: Tycho Andersen <[email protected]>
|
yeah, i'm hopeful it's just a regression. |
we are seeing:
2.947 go: github.com/opencontainers/image-tools/cmd/oci-image-tool imports
2.947 github.com/Sirupsen/logrus: github.com/Sirupsen/[email protected]: parsing go.mod:
2.947 module declares its path as: github.com/sirupsen/logrus
2.947 but was required as: github.com/Sirupsen/logrus
in CI, hopefully this replace fixes it?