Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/runtimetest: use github.com/moby/sys/mountinfo #772

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Sep 6, 2023

I noticed that this package was a fork of an old version of the "mount" package
in the docker repository. This package was migrated to a separate module in the
github.com/moby/sys repository, which should be easy to consume now that it's
no longer insxide the docker repository.

This patch switches the local fork to the new module.

@thaJeztah thaJeztah force-pushed the use_mountinfo branch 2 times, most recently from d034327 to ab09d00 Compare September 14, 2023 15:11
@thaJeztah thaJeztah marked this pull request as ready for review September 14, 2023 15:11
@thaJeztah thaJeztah requested a review from a team as a code owner September 14, 2023 15:11
kolyshkin
kolyshkin previously approved these changes Aug 14, 2024
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kolyshkin
Copy link
Contributor

@thaJeztah can we bump this to mountinfo v0.7.2?

I noticed that this package was a fork of an old version of the "mount" package
in the docker repository. This package was migrated to a separate module in the
github.com/moby/sys repository, which should be easy to consume now that it's
no longer insxide the docker repository.

This patch switches the local fork to the new module.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Member Author

@kolyshkin updated; PTAL

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM, thanks!

@kolyshkin
Copy link
Contributor

@opencontainers/runtime-tools-maintainers PTAL

1 similar comment
@kolyshkin
Copy link
Contributor

@opencontainers/runtime-tools-maintainers PTAL

@thaJeztah
Copy link
Member Author

@tianon @cyphar this LGTY?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants