Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sys to support loong64 #764

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zhaixiaojuan
Copy link

Now the sys under the vendor directory does not support loong64, resulting in the following error when running on the LoongArch64 architecture:

go build -tags "" -ldflags "-X main.gitCommit=v0.9.0-105-ga469c0f -X main.version=0.9.0"  -o oci-runtime-tool ./cmd/oci-runtime-tool
# golang.org/x/sys/unix
vendor/golang.org/x/sys/unix/affinity_linux.go:14:20: undefined: _CPU_SETSIZE
vendor/golang.org/x/sys/unix/affinity_linux.go:14:35: undefined: _NCPUBITS
vendor/golang.org/x/sys/unix/affinity_linux.go:17:25: undefined: cpuMask
vendor/golang.org/x/sys/unix/sockcmsg_unix.go:33:9: undefined: Cmsghdr
vendor/golang.org/x/sys/unix/syscall_linux.go:436:11: undefined: RawSockaddrLinklayer
vendor/golang.org/x/sys/unix/syscall_linux.go:461:9: undefined: RawSockaddrNetlink
vendor/golang.org/x/sys/unix/syscall_linux.go:477:10: undefined: RawSockaddrHCI
vendor/golang.org/x/sys/unix/syscall_linux.go:494:11: undefined: RawSockaddrL2
vendor/golang.org/x/sys/unix/syscall_linux.go:543:6: undefined: RawSockaddrRFCOMM
vendor/golang.org/x/sys/unix/syscall_linux.go:574:10: undefined: RawSockaddrCAN
vendor/golang.org/x/sys/unix/syscall_linux.go:574:10: too many errors
make: *** [Makefile:16: tool] Error 2

To fix this, I updated the sys version.

@zhaixiaojuan zhaixiaojuan requested a review from a team as a code owner March 15, 2023 07:28
Signed-off-by: zhaixiaojuan <[email protected]>
@zhaixiaojuan
Copy link
Author

cc @tianon

@bryantbiggs
Copy link

@zhaixiaojuan this looks like it needs a rebase or should it be closed in favor of #765 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants