Skip to content

Commit

Permalink
Remove log that is always generated for annotation fields. (#652)
Browse files Browse the repository at this point in the history
 * (M) ytypes/container.go
  - Since schemas that are generated with annotations will always
    generate the log that says that unmarshal into them is unsupported
    the log message produced is extremely low value to a user. To this
    end - just remove it.
  • Loading branch information
robshakir authored Apr 22, 2022
1 parent 473d130 commit f9339e1
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions ytypes/container.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import (
"reflect"
"strings"

log "github.com/golang/glog"
"github.com/kylelemons/godebug/pretty"
"github.com/openconfig/goyang/pkg/yang"
"github.com/openconfig/ygot/util"
Expand Down Expand Up @@ -158,7 +157,6 @@ func unmarshalStruct(schema *yang.Entry, parent interface{}, jsonTree map[string
// Skip annotation fields since they do not have a schema.
// TODO(robjs): Implement unmarshalling annotations.
if util.IsYgotAnnotation(ft) {
log.Infof("ignoring annotation field %s during unmarshalling, unsupported", ft.Name)
// We need to find the paths that we should have unmarshalled here to avoid
// throwing errors to users whilst there is a TODO above.
paths, err := pathTagFromField(ft)
Expand Down

0 comments on commit f9339e1

Please sign in to comment.