deploy - correct go install output #586
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon an invalid `kind` version, the following message is displayed: Error: failed to deploy cluster: failed to check for dependencies: kind version check failed: got 0.19.0, want 0.24.0. install with `go install sigs.k8s.io/[email protected]` Executing the instruction fails, due to an in-valid version tag: `go: sigs.k8s.io/[email protected]: sigs.k8s.io/[email protected]: invalid version: unknown revision 0.24.0` The `v` is being stripped off by `parseVersion` as changed in 1d152a. Since `parseVersion` explicitly requires a `v` prefix, it should be safe to just add this back in the human output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon an invalid
kindversion, the following message is displayed:Error: failed to deploy cluster: failed to check for dependencies: kind version check failed: got 0.19.0, want 0.24.0. install with
go install sigs.k8s.io/[email protected]Executing the instruction fails, due to an in-valid version tag:
go: sigs.k8s.io/[email protected]: sigs.k8s.io/[email protected]: invalid version: unknown revision 0.24.0The
vis being stripped off byparseVersionas changed in 1d152a.Since
parseVersionexplicitly requires avprefix, it should be safe to just add this back in the human output.