Issue152 - this issue's problem was actually already resolved but in reading - some cleanup of text seemed proper. #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some clarification that SSL Profiles maybe used for: * client services (services on a system which initiate connections) * server services (services on a system which receive connections) * both (clients and servers)
Cleanup a bit of the README content, mostly language fixes seen upon re-reading the readings.
marcushines
reviewed
Jan 2, 2025
|
Oddly the build of: //... I can try with bazel 7.4.1 to be sure. |
|
Yes, builds locally with 6.4 and 7.4 both work fine. #confused |
Make this BUILD target look like a working BUILD target (credentialz)
marcushines
approved these changes
Jan 6, 2025
morrowc
added a commit
that referenced
this pull request
Jan 22, 2025
…reading - some cleanup of text seemed proper. (#215) * Issue202: Add clarification on usage of ssl profiles. Add some clarification that SSL Profiles maybe used for: * client services (services on a system which initiate connections) * server services (services on a system which receive connections) * both (clients and servers) * Documentation Cleanup. Cleanup a bit of the README content, mostly language fixes seen upon re-reading the readings. * Address comment. * Attempting to fix a broken bazel build in github-actions. Make this BUILD target look like a working BUILD target (credentialz) * Add to the BUILD fixing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup some of the text in the readme, surrounding rotation content.