Add support for profiles in Get and Probe RPC. #213
Conversation
| // | ||
| // Note that the authz profile is considered independent from a SSL profile | ||
| // ID (as referenced by gnsi.Certz). | ||
| string authz_profile_id = 3; |
There was a problem hiding this comment.
I discussed with Marcus too. I think this makes sense to have here so that you can know exactly what authz policy you're probing.
However, can we add a clarification that says that you can only have one rotate operation in progress at once, to avoid the complexity of the state machine having to handle "what happens if you start multiple operations and then probe another one".
There was a problem hiding this comment.
I made a similar change for Certz here: #201
| // | ||
| // Note that the authz profile is considered independent from a SSL profile | ||
| // ID (as referenced by gnsi.Certz). | ||
| string authz_profile_id = 1; |
There was a problem hiding this comment.
Is this really 'ssl_profile_id'? or are there now new profiles inside profiles?
(authz inside ssl)
wait: "Note that the authz profile is considered..."
Why is that? are these tied back to the ssl profile in some way? how would I know that I'm using the a vs b profile here?
While profiles have been added into the rotation via #200, the Get and Probe RPCs have remained profile-less. If a client is able to add multiple profiles, it should also be able to get and probe these profiles individually.