Argument to RecordSubscribe should not be a stream. #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing the keepalive concept and mentioning the behavior the server can adopt to timeout a dead client.
morrowc
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Would ask a niranjan to have a gander here, but... this SEEMS ok to me:
- the request only has a timestamp: "tell me anything since X"
- I don't see you wanting to make that request often on the same connection
(you are just waiting around for more data, no need to re-ask)
overall seems ok, but :) 2x check would be nice.
|
huh, I can't add niranjan... maybe we poke him in another method to have a look |
This looks fine, lets incorporate the text in haussli@33b831a |
Raised #151 for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed this change in the previous merge.
issue #137