Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bazel8 support. #248

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add bazel8 support. #248

wants to merge 1 commit into from

Conversation

bstoll
Copy link
Contributor

@bstoll bstoll commented Jan 14, 2025

This PR updates GNOI to use Bazel8/bzlmod. This change also has makes Gazelle BUILD file generation work, which has resulted in fixing some consistency problems with import_prefix not being applied to all GNOI protos.

This PR is flagged as a draft because it pins openconfig_gnmi, openconfig_gnsi, and openconfig_bootz to my personal git branch. openconfig/gnmi#192 , openconfig/gnsi#220 and openconfig/bootz#147 need to be merged and uploaded to the Bazel Central Registry before this PR can be merged.

@bstoll bstoll mentioned this pull request Jan 14, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12759242402

Details

  • 35 of 2648 (1.32%) changed or added relevant lines in 36 files are covered.
  • 243 unchanged lines in 19 files lost coverage.
  • Overall coverage increased (+0.2%) to 1.308%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/common.pb.go 1 4 25.0%
bgp/bgp_grpc.pb.go 0 11 0.0%
factory_reset/factory_reset_grpc.pb.go 0 11 0.0%
bootconfig/bootconfig_grpc.pb.go 0 14 0.0%
debug/debug_grpc.pb.go 0 14 0.0%
otdr/otdr_grpc.pb.go 0 14 0.0%
packet_capture/packet_capture_grpc.pb.go 0 14 0.0%
bootconfig/bootconfig.pb.go 0 16 0.0%
bgp/bgp.pb.go 14 31 45.16%
diag/diag_grpc.pb.go 0 17 0.0%
Files with Coverage Reduction New Missed Lines %
common/common.pb.go 1 32.29%
bgp/bgp.pb.go 2 27.78%
debug/debug.pb.go 3 0.0%
bootconfig/bootconfig.pb.go 4 0.0%
factory_reset/factory_reset.pb.go 4 0.0%
types/types.pb.go 4 30.56%
mpls/mpls.pb.go 8 0.0%
otdr/otdr.pb.go 8 0.0%
wavelength_router/wavelength_router.pb.go 10 0.0%
packet_capture/packet_capture.pb.go 10 0.0%
Totals Coverage Status
Change from base Build 12758467056: 0.2%
Covered Lines: 162
Relevant Lines: 12389

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants