Update CI to run go 1.19 + go 1.20 #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcushines
approved these changes
Oct 31, 2023
Pull Request Test Coverage Report for Build 6712195061
💛 - Coveralls |
wenovus
requested changes
Nov 1, 2023
There was a problem hiding this comment.
This already is doing the actions that have been added:
https://github.com/openconfig/common-ci/blob/8f3db83e5548415f4f3999e42dd5f9bf7a203837/.github/workflows/basic_go.yml#L10
oldstable and stable are the latest two versions of Go, which is exactly what Go supports. Therefore 1.21 and 1.20 are already supported.
If other versions are needed, then can use this flag to override the defaults: https://github.com/openconfig/kne/blob/d973219c357631e67745329985c2771499e6181c/.github/workflows/go.yml#L18
|
I think this predated the commonci workflow being added. I'll close it since I don't think we need it right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update versions in
go.ymlto run latest versions of Go.