Don't rely on subscription configuration to get subscription name #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the API directly, there is not subscription configuration (it is set in the app module) and we cannot use it to get the name. Instead, use the name provided in the function call. This is a regression introduced in openconfig#331.
|
This PR is now OK for me. |
karimra
approved these changes
Jan 18, 2024
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the API directly, there is not subscription configuration (it is set in the app module) and we cannot use it to get the name. Instead, use the name provided in the function call.
This is a regression introduced in #331.
I am a bit unsure if this is the only regression as my tests are now failing. I am just quickly firing this one so you don't work on my comments in #331 in parallel.