[DASH] Update headers changes due to autogen #2027
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marian Pritsak <[email protected]>
kcudnik
reviewed
Jun 6, 2024
| /** | ||
| * @brief Notification data format received from SAI HA scope callback | ||
| */ | ||
| typedef struct _sai_ha_scope_event_data_t | ||
| { | ||
| /** Event type */ | ||
| sai_ha_scope_event_t event_type; |
There was a problem hiding this comment.
such changes will not be backward compatible
There was a problem hiding this comment.
if we put this event data at the end, will this be backward compatible?
There was a problem hiding this comment.
no xD chanigng struct size will not be backward compatible at all, but if you need to add something, add it at the end
kcudnik
reviewed
Jun 6, 2024
| @@ -74,6 +74,8 @@ typedef enum _sai_object_type_extensions_t | |||
|
|
|||
| SAI_OBJECT_TYPE_HA_SCOPE, | |||
|
|
|||
| SAI_OBJECT_TYPE_ROUTING_GROUP, | |||
There was a problem hiding this comment.
similar here adding at the middle
kcudnik
reviewed
Jun 6, 2024
|
|
||
| /** DASH ENI INLINE_FLOW_DELETE_ACK_IGNORED_RECV stat count */ | ||
| SAI_ENI_STAT_INLINE_FLOW_DELETE_ACK_IGNORED_RECV, | ||
| /** DASH ENI INLINE_FLOW_DELETE_ACK_IGNORED stat count */ |
There was a problem hiding this comment.
changing enums names also wil not be backward compatible
|
Yea, we need to at least get this change in before the generator produces non-compatible code: sonic-net/DASH#578. It is pending on sonic-net/DASH#576, which is pending on sonic-net/DASH#577. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.