[as9726_32d] Add new platform #883

acctalex · 2022-04-19T09:06:43Z

CPU: Intel Broadwell-DE D-1519 4 cores
RAM: DDR4 8GB x2 SO-DIMM (Expandable up to 16GBx2, w/i ECC)
SSD: M.2 MLC 50GB x 1
PHY: Marvell 88E1111
CPLD: Altera MAX 10 10M04DAU324C8G X1
CPLD: Altera Cyclone IV EP4CGX30CF23C7N X1
CPLD: Altera 5M1270ZF256C5N x1
Ethernet Port: 400G QSFP56-DD port x 32 and 10G SFP+ x 2
PSU: 1+1 Redundant/hot swappable 1500W AC/DC PSU (C14 ac inlet)
Cooling: 5+1 fan-tray modules with 40mm x40mm x 56mm 12V fans, hotswappable
Dimension: 17.26” x 23.23” x 1U (438.4x590x43.5mm)
Linux kernel version: 5.4, due to customer requirements

Signed-off-by: Alex Lai [email protected]

CPU: Intel Broadwell-DE D-1519 4 cores RAM: DDR4 8GB x2 SO-DIMM (Expandable up to 16GBx2, w/i ECC) SSD: M.2 MLC 50GB x 1 PHY: Marvell 88E1111 CPLD: Altera MAX 10 10M04DAU324C8G X1 CPLD: Altera Cyclone IV EP4CGX30CF23C7N X1 CPLD: Altera 5M1270ZF256C5N x1 Ethernet Port: 400G QSFP56-DD port x 32 and 10G SFP+ x 2 PSU: 1+1 Redundant/hot swappable 1500W AC/DC PSU (C14 ac inlet) Cooling: 5+1 fan-tray modules with 40mm x40mm x 56mm 12V fans, hotswappable Dimension: 17.26” x 23.23” x 1U (438.4x590x43.5mm) Signed-off-by: Alex Lai <[email protected]>

paulmenzel

Thank you for adding the device. Please mention the Linux kernel version in the commit message.

Did you send the Linux kernel patches upstream for review?

paulmenzel · 2022-04-19T09:40:08Z

...es/platforms/accton/x86-64/as9726_32d/onlp/builds/x86_64_accton_as9726_32d/module/src/ledi.c

+{LED_DIAG, LED_MODE_OFF,   ONLP_LED_MODE_OFF},
+{LED_DIAG, LED_MODE_GREEN, ONLP_LED_MODE_GREEN},
+{LED_DIAG, LED_MODE_AMBER, ONLP_LED_MODE_ORANGE},
+{LED_DIAG, LED_MODE_GREEN_BLINK, ONLP_LED_MODE_GREEN_BLINKING},
+{LED_LOC,  LED_MODE_OFF,   ONLP_LED_MODE_OFF},
+{LED_LOC,  LED_MODE_AMBER,   ONLP_LED_MODE_ORANGE},
+{LED_LOC,  LED_MODE_AMBER_BLINK,  ONLP_LED_MODE_ORANGE_BLINKING},
+{LED_FAN,  LED_MODE_AUTO,  ONLP_LED_MODE_AUTO},
+{LED_PSU1, LED_MODE_AUTO,  ONLP_LED_MODE_AUTO},
+{LED_PSU2, LED_MODE_AUTO,  ONLP_LED_MODE_AUTO}


Incorrect indentation?

paulmenzel · 2022-04-19T09:41:24Z

packages/platforms/accton/x86-64/as9726_32d/modules/builds/x86-64-accton-as9726-32d-psu.c

+
+		if (unlikely(result != data_len)) {
+			result = -EIO;
+			msleep(10);


Why such a high delay?

10 ms delay is not so high here. I think.

Everything about 1 ms is high, and should be justified.

paulmenzel · 2022-04-19T09:41:44Z

packages/platforms/accton/x86-64/as9726_32d/modules/builds/x86-64-accton-as9726-32d-psu.c

+		int status;
+		int power_good = 0;
+
+		dev_dbg(&client->dev, "Starting as9726_32d update\n");


Why update?

in order to return the most up to date value, an update is needed.

But what is updated? Please improve the debug message.

paulmenzel · 2022-04-19T09:42:04Z

packages/platforms/accton/x86-64/as9726_32d/modules/builds/x86-64-accton-as9726-32d-psu.c

+
+		if (status < 0) {
+			dev_dbg(&client->dev, "cpld reg 0x60 err %d\n", 
+				status);


Fits on line above.

paulmenzel · 2022-04-19T09:43:27Z

packages/platforms/accton/x86-64/as9726_32d/modules/builds/x86-64-accton-as9726-32d-psu.c

+		if (status < 0) {
+			dev_dbg(&client->dev, "cpld reg 0x60 err %d\n", 
+				status);
+		} else {
+			data->status = status;
+		}


No curly braces if all branches only consist of one single line.

paulmenzel · 2022-04-19T09:44:04Z

packages/platforms/accton/x86-64/as9726_32d/modules/builds/Makefile

@@ -0,0 +1,6 @@
+KERNELS := onl-kernel-4.19-lts-x86-64-all:amd64


Why not the latest Linux kernel version?

our customers need the 4.19 kernel.

Please mention that in the commit message. (I am very uneasy about the fact, that users rely on such old versions, even if they are LTS series. For ONL the latest Linux kernel version should always be usable.)

…onality, and to use correct settings. 1. removed the old project name in fan.c. 2. removed unnecessary mutex_unlock() in fan.c. 3. added AIM_FREE_IF_PTR(mn) in platform_lib.c to prevent memory leak. 4. added support of Belpower psu. 5. added support of transciever LP mode sysfs and onlpdump. 6. modified the fan policy. 7. modified to use the fan air flow direction to detemine which set of thermal thersholds should be used. 8. modified to use the correct console port setting. 9. removed IR3570 related codes in __init__.py 10. modified some codes to fit the linux coding style. Signed-off-by: Alex Lai <[email protected]>

1. used kernel 5.4 2. removed msleep(10) when failed to read correct PSU info. Signed-off-by: Alex Lai <[email protected]>

1. initialize pca9548 idle_state in kernel 5.4.40 version, or the data read by the transceivers will be wrong. Signed-off-by: Alex Lai <[email protected]>

1. Modify PSU related files to support new PSU model:FSJ035-610G and FSJ036-610G. 2. Modify to show correct fan direction for FSJ001, FSJ004, SPAACTN-01, and SPAACTN-02 3. Modify to show the current PSU is of AC or DC. 4. Modify to let vout, vin, iout, iin, pout, and pin return 0, if the PSU is present but unplugged. Signed-off-by: Alex Lai <[email protected]>

1. In onlpdump, modified to read the fan direction of each psu and show, instead of one reffering to other. Signed-off-by: Alex Lai <[email protected]>

1. used the comunity master branch's x86_64-all.config of kernel 5.4. Signed-off-by: Alex Lai <[email protected]>

paulmenzel · 2024-01-17T07:56:29Z

Please mention the used Linux kernel version in the commit message description of commit [as9726_32d] Add new platform, and say why. The latest LTS version is 6.6.

acctalex · 2024-01-24T09:32:29Z

Please mention the used Linux kernel version in the commit message description of commit [as9726_32d] Add new platform, and say why. The latest LTS version is 6.6.

OK, done. Please review, thanks.

jeff97830133 · 2024-02-20T08:03:10Z

Hello @paulmenzel

Please help review this PR.
Thanks!!

1. Use the eeprom at 0x56 on the mainbaord, and the eeprom at 0x57 on the cpu board will no longer be used. Signed-off-by: Alex Lai <[email protected]>

paulmenzel suggested changes Apr 19, 2022

View reviewed changes

acctalex added 5 commits May 4, 2022 08:22

[accton/as9726_32d] used kernel 5.4 and corrected the PSU's delay

bdb39bc

1. used kernel 5.4 2. removed msleep(10) when failed to read correct PSU info. Signed-off-by: Alex Lai <[email protected]>

[accton/as9726_32d] initialize pca9548 idle_state

8cf5492

1. initialize pca9548 idle_state in kernel 5.4.40 version, or the data read by the transceivers will be wrong. Signed-off-by: Alex Lai <[email protected]>

Merge remote-tracking branch 'upstream/master' into as9726_32d

f08e7b0

Merge remote-tracking branch 'upstream/master' into as9726_32d

edf7b15

acctalex force-pushed the as9726_32d branch 3 times, most recently from 83e60f3 to edf7b15 Compare August 2, 2023 07:59

acctalex added 4 commits August 2, 2023 08:36

[Edgecore][as9726-32d] Modified PSU fan dir. detection method in onlpd

f2f24c3

1. In onlpdump, modified to read the fan direction of each psu and show, instead of one reffering to other. Signed-off-by: Alex Lai <[email protected]>

[Edgecore][as9726-32d] changed the x86_64-all.config of kernel 5.4

5ac3975

1. used the comunity master branch's x86_64-all.config of kernel 5.4. Signed-off-by: Alex Lai <[email protected]>

Merge remote-tracking branch 'upstream/master' into as9726_32d

b53e5e1

acctalex requested a review from paulmenzel January 16, 2024 03:48

Alex Lai added 2 commits September 25, 2024 01:49

Merge remote-tracking branch 'upstream/master' into as9726_32d

de8eccc

[Accton][as9726-32d] Use the eeprom on the mainboard

5ea910b

1. Use the eeprom at 0x56 on the mainbaord, and the eeprom at 0x57 on the cpu board will no longer be used. Signed-off-by: Alex Lai <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[as9726_32d] Add new platform #883

[as9726_32d] Add new platform #883

acctalex commented Apr 19, 2022 •

edited

Loading

paulmenzel left a comment

paulmenzel Apr 19, 2022

paulmenzel Apr 19, 2022

acctalex May 4, 2022

paulmenzel May 4, 2022

paulmenzel Apr 19, 2022

acctalex May 4, 2022

paulmenzel May 4, 2022

paulmenzel Apr 19, 2022

paulmenzel Apr 19, 2022

paulmenzel Apr 19, 2022

acctalex May 4, 2022

paulmenzel May 4, 2022

paulmenzel commented Jan 17, 2024

acctalex commented Jan 24, 2024

jeff97830133 commented Feb 20, 2024

		@@ -0,0 +1,6 @@
		KERNELS := onl-kernel-4.19-lts-x86-64-all:amd64

[as9726_32d] Add new platform #883

Are you sure you want to change the base?

[as9726_32d] Add new platform #883

Conversation

acctalex commented Apr 19, 2022 • edited Loading

paulmenzel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paulmenzel commented Jan 17, 2024

acctalex commented Jan 24, 2024

jeff97830133 commented Feb 20, 2024

acctalex commented Apr 19, 2022 •

edited

Loading