Fix incognito pm update #10960
Open
Fix incognito pm update #10960
+47
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Betree
reviewed
Jan 30, 2025
Solves a case where the hook is called again during component render and a new payment intent is created with same parameters by the previously in-flight mutation call. This causes an unused payment intent on Stripe and rerenders the form with new state. |
Betree
approved these changes
Feb 5, 2025
| // If this hook is called again during component rerender and we still have a in-flight payment intent, abort it. | ||
| // Without the abort controller, we can get another payment intent created for a previous render that will be unused | ||
| // and will make the form render again with the setStripe, setPaymentIntent state changes. This also prevents generating | ||
| // to many incomplete payment intents on stripe |
There was a problem hiding this comment.
Suggested change
| // to many incomplete payment intents on stripe | |
| // too many incomplete payment intents on stripe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves opencollective/opencollective#7770