Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Naver Cloud Wrapper #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jsmoon-openerd
Copy link

@jsmoon-openerd jsmoon-openerd commented Jun 15, 2024

Add KMIP, Naver Cloud, PKCS#11 Wrapper

The KMIP wrapper has been tested with PyKMIP.

KMIP currently support AES encryption algorithm.

PKCS#11 currently support RSA, AES encryption algorithm.

openbao/openbao#300

Signed-off-by: jsmoon <[email protected]>
@jsmoon-openerd jsmoon-openerd changed the title Add KMIP, Naver Cloud Wrapper Add KMIP, Naver Cloud, PKCS#11 Wrapper Jun 15, 2024
@jsmoon-openerd jsmoon-openerd force-pushed the ncloud branch 3 times, most recently from 883cb22 to 027bfbb Compare June 16, 2024 06:34
@cipherboy
Copy link
Member

Wow @jsmoon-openerd! This looks fairly comprehensive on first glance. I'll have to take more time this weekend to review the PR. Thank you!

I am a little worried about the size of go-kms-wrapping, what's your thoughts on eventually splitting it into a plugin architecture? If we make go-kms-wrapping v3 be PKCS#11 only, we can take the existing providers and turn them into PKCS#11 client libraries (especially where ones don't exist already)... Thoughts?

@cipherboy cipherboy self-requested a review June 20, 2024 12:41
@cipherboy
Copy link
Member

Hey @jsmoon-openerd, do you mind splitting this into three PRs, one for each new backend? Thanks in advance!

@cipherboy cipherboy requested a review from DanGhita June 20, 2024 13:49
This was referenced Jun 21, 2024
@jsmoon-openerd jsmoon-openerd changed the title Add KMIP, Naver Cloud, PKCS#11 Wrapper Add Naver Cloud Wrapper Jun 21, 2024
@cipherboy
Copy link
Member

\o hello @jsmoon-openerd -- as discussed on yesterday's community call, we're going to hold off on these three PRs until after GA, to continue letting GA stabilize before then. Thanks for your understanding and patience. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants