package: Set LD_LIBRARY_PATH for tests to work against shared library #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a shared library is built, we need to have the test suite attempt to use our newly built shared library. Without this, it fails with unresolved symbols.
|
Actually the test suite does know how to use the newly built library, that's a cmake feature. So I'm kind of puzzled how you get errors. |
|
@mlschroe It did not work until I made that change for my build here: https://build.opensuse.org/package/rdiff/home:Pharaoh_Atem:DNF_SUSE:DNF5/libsolv?linkrev=base&rev=2 |
|
@mlschroe Note this is only broken on openSUSE, as I don't have this problem on Fedora or Mageia. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a shared library is built, we need to have the test suite attempt to
use our newly built shared library. Without this, it fails with unresolved
symbols.