Impose that user always passes iteration or t #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
changed the title
|
Thanks for this change! |
ax3l
approved these changes
Aug 9, 2023
ax3l
reviewed
Aug 9, 2023
ax3l
reviewed
Aug 9, 2023
Co-authored-by: Axel Huebl <[email protected]>
…ewer into no_default_iteration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user does not pass
toriteration, the default behavior was to reuse the last iteration that was accessed. This can sometimes result in behavior that the user would not expected.Instead, this PR imposes that
toriterationalways be specified.