FINERACT-2092: Payment Waiver - UI changes #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somasorosdpc
force-pushed
the
FINERACT-2092/introduce-payment-waiver-for-ui
branch
from
66bd852
to
c3386a8
Compare
| { | ||
| name: 'Payment Waiver', | ||
| icon: 'coins', | ||
| taskPermissionName: 'CREATE_GOODWILL_TRANSACTION', |
There was a problem hiding this comment.
Please fix this permission for Payment Waiver
src/assets/translations/en-US.json
Outdated
| @@ -2414,6 +2414,7 @@ | |||
| "Navigation": "Navigation", | |||
| "Notifications": "Notifications", | |||
| "Organization": "Organization", | |||
| "Payment Waiver": "Payment Waiver", | |||
There was a problem hiding this comment.
Please add the other translations for the rest of the languages supported
somasorosdpc
force-pushed
the
FINERACT-2092/introduce-payment-waiver-for-ui
branch
2 times, most recently
from
123c2b7
to
4e523f3
Compare
adamsaghy
reviewed
Jun 17, 2024
| @@ -2413,7 +2413,8 @@ | |||
| "Navigation": "Urambazaji", | |||
| "Notifications": "Arifa", | |||
| "Organization": "Shirika", | |||
| "Payments": "Malipo", | |||
There was a problem hiding this comment.
I reckon here you have modified the wrong translation key!
adamsaghy
requested changes
Jun 17, 2024
somasorosdpc
force-pushed
the
FINERACT-2092/introduce-payment-waiver-for-ui
branch
2 times, most recently
from
0d8d202
to
dfba9e9
Compare
somasorosdpc
force-pushed
the
FINERACT-2092/introduce-payment-waiver-for-ui
branch
from
dfba9e9
to
fee0f7a
Compare
somasorosdpc
force-pushed
the
FINERACT-2092/introduce-payment-waiver-for-ui
branch
from
fee0f7a
to
4c27aca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UI changes to introduce Payment Waiver repayment type and Advanced payment allocation for loan products.
Related issues and discussion
#{FINERACT-2092}
Screenshots, if any
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.