-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FINERACT-2092: Payment Waiver - UI changes #2123
FINERACT-2092: Payment Waiver - UI changes #2123
Conversation
66bd852
to
c3386a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review my comments
{ | ||
name: 'Payment Waiver', | ||
icon: 'coins', | ||
taskPermissionName: 'CREATE_GOODWILL_TRANSACTION', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix this permission for Payment Waiver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
src/assets/translations/en-US.json
Outdated
@@ -2414,6 +2414,7 @@ | |||
"Navigation": "Navigation", | |||
"Notifications": "Notifications", | |||
"Organization": "Organization", | |||
"Payment Waiver": "Payment Waiver", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the other translations for the rest of the languages supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
123c2b7
to
4e523f3
Compare
@@ -2413,7 +2413,8 @@ | |||
"Navigation": "Urambazaji", | |||
"Notifications": "Arifa", | |||
"Organization": "Shirika", | |||
"Payments": "Malipo", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reckon here you have modified the wrong translation key!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please kindly check the review comments!
0d8d202
to
dfba9e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dfba9e9
to
fee0f7a
Compare
fee0f7a
to
4c27aca
Compare
Description
UI changes to introduce Payment Waiver repayment type and Advanced payment allocation for loan products.
Related issues and discussion
#{FINERACT-2092}
Screenshots, if any
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md
.