-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix annotate for chunked operations like in insulation #422
Conversation
I had to add the recently removed export of _IndexingMixin, since cooltools uses it... |
@nvictus would you be able to review? We should release a fix asap |
This needs a test case that triggers the error without the fix. |
We can restore it in a patch, but cooltools needs to vendor it in, because it is not part of cooler's public API and I'll remove it again in the next minor release. |
Thank you @nvictus! Of course numpy 2.0 breaks stuff, so the tests here fail... |
Great opportunity to throw in the numpy major version pin. |
Looks like disallowing numpy 2.0 makes the tests pass! Shall we merge and make a bugfix release? |
Simple solution with .loc instead of .iloc - probaly a bit slower, perhaps some arithmetic can fix the .iloc to behave correctly