Logger in go #348
Closed
Logger in go #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openapiart/sample_log_test.go
Outdated
| @@ -0,0 +1,13 @@ | |||
| package openapiart_test | |||
There was a problem hiding this comment.
move this test to pkg where other tests are present
pkg/unit_test.go
Outdated
| @@ -1667,11 +1667,8 @@ func TestClone(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestLogging(t *testing.T) { | |||
| openapiart.NewApi() | |||
| api := openapiart.NewApi() | |||
| api.SetLoggerLevel("info") | |||
There was a problem hiding this comment.
change the loglevel input Ex: "info" to enum
ANISH-GOTTAPU
previously approved these changes
Jul 26, 2022
ANISH-GOTTAPU
dismissed
their stale review
As discussed, we need to add more logging in the generated SDKs
|
Covered by #422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #346