-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify builders across signals #2220
base: main
Are you sure you want to change the base?
Unify builders across signals #2220
Conversation
3cdff17
to
8b09a51
Compare
There were some concerns about having |
8b09a51
to
fc0d3c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments but looks good overall.
Please check the comments and see if they make sense.
yes I suggest to hide Arc inside. |
1d0ea2f
to
02574ef
Compare
@stormshield-fabs Thanks a lot! I think the following are to be addressed before merge. We also need to write a migration guide in the PR description showing before/after, so users can easily (relatively) react to this. Lets keep InstrumentationScope simple, and accept the perf cost now, given it is infrequent operation. Rename library-signal to something like signal_with_scope/better names. |
c19353a
to
1b41f6c
Compare
1912ce4
to
f3c67cd
Compare
f3c67cd
to
a6bd2db
Compare
Fixes #1527 #2164
Changes
The consensus reached during the SIG meeting is that we'd like to unify the builder APIs across signals, limit duplication and keep our traits object-safe. Proposed changed :
Logger
andTracer
builders that were only used to wrap theInstrumentationLibrary
builderversioned_
methods on providersProvider::signal(name: &str)
andProvider::library_signal(library: Arc<InstrumentationLibrary>)
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes