Provide advisory histogram boundaries when creating OpenAI metrics #3225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned alizenhom, codefromthecrypt, gyliu513, karthikscale3, lmolkova, lzchen and nirga
github-actions
bot
requested review from
alizenhom,
codefromthecrypt,
gyliu513,
karthikscale3,
lzchen and
nirga
|
LGTM |
codefromthecrypt
approved these changes
Feb 3, 2025
instrumentation-genai/opentelemetry-instrumentation-openai-v2/examples/manual/main.py
Outdated
Show resolved
Hide resolved
aabmass
approved these changes
Feb 3, 2025
codefromthecrypt
approved these changes
Feb 4, 2025
| views = [ | ||
| View( | ||
| instrument_name="gen_ai.client.token.usage", | ||
| aggregation=ExplicitBucketHistogramAggregation( |
There was a problem hiding this comment.
IIUC what we are doing is avoiding the default boundaries being used both for token usage and also duration.
From here
_DEFAULT_EXPLICIT_BUCKET_HISTOGRAM_AGGREGATION_BOUNDARIES: Sequence[float] = (
0.0,
5.0,
10.0,
25.0,
50.0,
75.0,
100.0,
250.0,
500.0,
750.0,
1000.0,
2500.0,
5000.0,
7500.0,
10000.0,
)So, this default might be ok for tokens for some apps, but probably not reasonable for durations which are in seconds (except maybe in reasoning models ;)). Correct me if I'm wrong!
xrmx
approved these changes
Feb 6, 2025
lmolkova
changed the title
codefromthecrypt
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3235
Update:
I overhauled this PR and it now leverages advisory boundaries - no need for users to configure anything and most users should have good experience with default boundaries. So no OpenAI-specific example is necessary.