Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(instrumentation-generic-pool): Include all versions in coverage #2683

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

onurtemizkan
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Runs v2 to 2.4, v2.4 to v3 and v3+ tests in the test command to make sure they are included in the coverage report

@github-actions github-actions bot added pkg:instrumentation-generic-pool pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. labels Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.18%. Comparing base (fcca38a) to head (7acf180).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2683      +/-   ##
==========================================
+ Coverage   90.95%   91.18%   +0.23%     
==========================================
  Files         172      172              
  Lines        8137     8137              
  Branches     1649     1649              
==========================================
+ Hits         7401     7420      +19     
+ Misses        736      717      -19     

see 2 files with indirect coverage changes

@onurtemizkan onurtemizkan marked this pull request as ready for review January 27, 2025 19:34
@onurtemizkan onurtemizkan requested a review from a team as a code owner January 27, 2025 19:34
Copy link
Contributor

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:instrumentation-generic-pool pkg-status:unmaintained:autoclose-scheduled pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant