-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(oracledb): Add support for Oracle DB instrumentation #2612
base: main
Are you sure you want to change the base?
Conversation
Add Oracledb instrumentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rename the new types to TitleCase to follow the rest of the code ?
Yes renamed to TitleCase for types and internal-types exported. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2612 +/- ##
==========================================
+ Coverage 90.78% 90.95% +0.16%
==========================================
Files 169 172 +3
Lines 8055 8224 +169
Branches 1643 1693 +50
==========================================
+ Hits 7313 7480 +167
- Misses 742 744 +2
|
The earlier triggered CI failure seems to be this. It looks related to some package version dependency ,
|
Please help me with steps for updating |
Add Oracledb instrumentation
Which problem is this PR solving?
Adding instrumentation support for node-oracledb applications connecting to Oracle database.
Short description of the changes
From node-oracledb version 6.7 onwards, oracledb module exports a class,
TraceHandlerBase
which simulates interface kind of functionality with abstract methods to be overwritten by the derived class.The current OT module derives this class
TraceHandlerBase
and implements abstract methods; It usessetTraceInstance
method oforacledb
module to register this new derived classOracleTelemetryTraceHandler
These methods are invoked by
oracledb
module providing thetraceContext
which is used to dump the data in to the span after converting to standard span attributes.Following are the abstract methods implemented:
oracledb
module when application invokesgetConnection
to create a connection todatabase or
execute
method to run a sql. It is invoked before invoking the public API calls made by application.Note: