fix(deps): update spotless packages to v7 (major) #13004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/major-spotless-packages
branch
from
999a6ec to
5c8134f
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
laurit
reviewed
Jan 8, 2025
| @@ -97,7 +99,7 @@ if (project == rootProject) { | |||
| "**/*.dockerfile", | |||
| "**/gradle.properties" | |||
| ) | |||
| indentWithSpaces() | |||
| leadingTabsToSpaces() | |||
There was a problem hiding this comment.
indentWithSpaces is deprecated and replaced with leadingTabsToSpaces
laurit
reviewed
Jan 8, 2025
| "ktlint_standard_property-naming" to "disabled" | ||
| "ktlint_standard_property-naming" to "disabled", | ||
| // prevent moving comment to next line in latestDepTestLibrary("xxx") { // see xxx module | ||
| "ktlint_standard_function-literal" to "disabled" |
There was a problem hiding this comment.
without disabling this rule we'd end up with
latestDepTestLibrary("xxx") {
// see xxx module
that breaks the script that checks the latestDepTestLibrary dependencies
laurit
reviewed
Jan 8, 2025
| return flow.onCompletion { cause: Throwable? -> | ||
| instrumenter.end(context, request, null, cause) | ||
| } | ||
| fun <REQUEST, RESPONSE> onComplete(flow: Flow<*>, instrumenter: Instrumenter<REQUEST, RESPONSE>, context: Context, request: REQUEST & Any): Flow<*> = flow.onCompletion { cause: Throwable? -> |
There was a problem hiding this comment.
It doesn't really seem to honor the max line length here. I guess if there is interest we could track down which rule removes the {} to avoid creating such long lines.
laurit
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
6.25.0->7.0.16.25.0->7.0.1Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.