Feat add a test case in AbstractHttpClientTest.java #12924
Merged
+24
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Dec 31, 2024
| @@ -131,6 +133,7 @@ default Builder withDefaults() { | |||
| .setTestCallbackWithParent(true) | |||
| .setTestErrorWithCallback(true) | |||
| .setTestNonStandardHttpMethod(true) | |||
| .setTestClientError(true) | |||
There was a problem hiding this comment.
if a test is always enabled then there is no need to add an option to disable it
laurit
reviewed
Dec 31, 2024
| @@ -1029,6 +1029,34 @@ void spanEndsAfterHeadersReceived() throws Exception { | |||
| }); | |||
| } | |||
|
|
|||
| @Test | |||
| void requestClientError() throws Exception { | |||
There was a problem hiding this comment.
this is essentially a copy of errorSpan test, perhaps it would make sense to parameterize that test instead
|
hi @shalk! can you update the PR description to include the motivation for this test? thanks |
shalk
changed the title
laurit
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BackGroup:
In origin jaxrs-client 2.0-testing groovy file there is a test case relate to http test.
The test case is client error , send http request with path
/client-errorto server and return400http status code.Laurit advise to add this case for all http test.
cc @trask