-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support metrics for otelmux #6648
feat: support metrics for otelmux #6648
Conversation
Thank you for this! ❤️ This PR does a lot more than just setup semconv.
Striving for atomic PRs (each PR changes a single thing) makes for much speeder reviews. |
instrumentation/github.com/gorilla/mux/otelmux/internal/semconv/gen.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/gorilla/mux/otelmux/request/resp_writer_wrapper.go
Fixed
Show fixed
Hide fixed
thankyou for the feedback @dmathieu ! ❤️
This approach should make the review process smother and more efficient. i'll prioritize reorganizing these changes and will submit the individual PRs soon. Let me know if there are any additional points you'd like me to address. |
50b35e9
to
379f764
Compare
379f764
to
225115d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6648 +/- ##
=======================================
+ Coverage 73.8% 73.9% +0.1%
=======================================
Files 195 195
Lines 16627 16671 +44
=======================================
+ Hits 12285 12335 +50
+ Misses 3982 3978 -4
+ Partials 360 358 -2
|
Co-authored-by: Damien Mathieu <[email protected]>
Address issue #6638