Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/sqlquery] Decrease time of running integration tests #37624

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[receiver/sqlquery] Decrease time of running integration tests #37624

wants to merge 1 commit into from
+304 −240

Conversation

Grandys
Copy link
Contributor

@Grandys Grandys commented Jan 31, 2025 •
edited
Loading

Description

Improvements to integration test:

  1. Reduced test execution time by changing the behavior from starting and shutting down the database container for each test case to starting the container once and then running all tests for the given engine. Gain ~22s:

Main job:

DONE 47 tests, 8 skipped in 136.005s

PR job

DONE 44 tests, 4 skipped in 114.374s
  1. Updated the Oracle container from gvenzl/oracle-xe:21-slim-faststart to gvenzl/oracle-free:slim-faststart, primarily to support ARM architecture.

Testing

  • Ran tests for Oracle and SQL Server locally to ensure they are not broken.

@Grandys Grandys requested review from dmitryax, crobert-1 and a team as code owners January 31, 2025 17:37
@github-actions github-actions bot added the receiver/sqlquery SQL query receiver label Jan 31, 2025
@crobert-1 crobert-1 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@crobert-1 crobert-1 Awaiting requested review from crobert-1 crobert-1 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@dmitryax dmitryax

Labels
receiver/sqlquery SQL query receiver Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Grandys @dmitryax @crobert-1