[chore] Make additional config validation tests more resilient #37594
+60
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-bradley
requested review from
dashpole,
a team,
djaglowski,
dmitryax,
TylerHelmuth and
ChrsMark
as code owners
github-actions
bot
added
receiver/dockerstats
receiver/hostmetrics
receiver/k8scluster
receiver/podman
receiver/postgresql
receiver/prometheus
github-actions
bot
requested review from
alxbl,
Aneurysm9,
braydonk,
jamesmoessis,
mcardy,
pjanotti,
povilasv and
rogercoll
songy23
reviewed
Jan 30, 2025
receiver/hostmetricsreceiver/internal/scraper/filesystemscraper/filesystem_scraper_test.go
Outdated
Show resolved
Hide resolved
bogdandrutu
reviewed
Jan 30, 2025
| @@ -84,7 +84,7 @@ func TestConfigValidateMissingAuth(t *testing.T) { | |||
| cfg := createDefaultConfig().(*Config) | |||
| cfg.Queue = "someQueue" | |||
| err := component.ValidateConfig(cfg) | |||
| assert.Equal(t, errMissingAuthDetails, err) | |||
| assert.ErrorContains(t, err, errMissingAuthDetails.Error()) | |||
There was a problem hiding this comment.
The motivation for these changes is open-telemetry/opentelemetry-collector#12108, which prints the path in the config that produced this error. I don't want to depend on the format of the error message produced by component.ValidateConfig, only the part of the error produced by this component.
pjanotti
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #37579. This should address issues with the remaining tests.