-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/clickhouse] Add client info for identifying exporter in system.query_log
#37146
base: main
Are you sure you want to change the base?
[exporter/clickhouse] Add client info for identifying exporter in system.query_log
#37146
Conversation
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
not stale 👉 |
…tor-contrib into ch-otel-user-agent
…tor-contrib into ch-otel-user-agent
…emetry-collector-contrib into ch-otel-user-agent
@dmitryax I have updated the code to use Overall the code is simpler though, let me know if anything else stands out. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes look ok to me.
Description:
(reopen from #34915)
This change will include information about the collector version and OS/Arch for every
INSERT
. Users can then track the origin of these queries insystem.query_log
. For an official build this will look something likeotelcol/v0.114.0
.This is implemented by setting
client_info_product
in the DSN. The underlying ClickHouse Go driver will then attach it upon connection. Users can already add their own version info inendpoint
orconnection_params
, but this change will now safely set or append to that value with the binary's information.Documentation:
client_product_info
Testing: