Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: access level #19

Merged
merged 2 commits into from
Nov 16, 2024
Merged

feat: access level #19

merged 2 commits into from
Nov 16, 2024

Conversation

ningkaiqiang
Copy link
Collaborator

Modify the access level of models and algorithms.

@ningkaiqiang ningkaiqiang added the bug Something isn't working label Nov 16, 2024
@ningkaiqiang ningkaiqiang self-assigned this Nov 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.47%. Comparing base (9e0bc91) to head (da1c9d0).

Files with missing lines Patch % Lines
Sources/FSRS/Models/FSRSModels.swift 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   89.43%   89.47%   +0.04%     
==========================================
  Files          11       11              
  Lines        1041     1045       +4     
==========================================
+ Hits          931      935       +4     
  Misses        110      110              
Flag Coverage Δ
unittests 89.47% <85.71%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ishiko732 ishiko732 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@L-M-Sherlock L-M-Sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ningkaiqiang ningkaiqiang merged commit 16afd57 into main Nov 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants