Minor updates (#18)

* Changed access levels * Modified access level * Updated default parameters * Update Sources/FSRS/Models/FSRSDefaults.swift * update codecov-action version --------- Co-authored-by: Jarrett Ye <[email protected]>
open-spaced-repetition · Nov 14, 2024 · 9e0bc91 · 9e0bc91
1 parent acb9528
commit 9e0bc91
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 12 deletions.
diff --git a/.github/workflows/swift.yml b/.github/workflows/swift.yml
@@ -35,7 +35,8 @@ jobs:
       with:
           output-file: ./coverage/lcov.info
 
-    - uses: codecov/codecov-action@v1
+    - name: Upload coverage reports to Codecov
+      uses: codecov/codecov-action@v4
       with:
         token: ${{ secrets.CODECOV_TOKEN }}
         file: ./coverage/lcov.info

diff --git a/Sources/FSRS/Algorithm/FSRS.swift b/Sources/FSRS/Algorithm/FSRS.swift
@@ -22,7 +22,7 @@ public class FSRS: FSRSAlgorithm {
         }
     }
 
-    override init(parameters: FSRSParameters) {
+    override public init(parameters: FSRSParameters) {
         super.init(parameters: parameters)
     }
 
@@ -84,7 +84,7 @@ public class FSRS: FSRSAlgorithm {
      * const recordLog = f.repeat(card, new Date(), repeatAfterHandler);
      * ```
      */
-    func `repeat`(
+    public func `repeat`(
         card: Card,
         now: Date,
         _ completion: ((_ log: IPreview) -> IPreview)? = nil

diff --git a/Sources/FSRS/Models/FSRSDefaults.swift b/Sources/FSRS/Models/FSRSDefaults.swift
@@ -9,11 +9,7 @@ import Foundation
 public class FSRSDefaults {
     var defaultRequestRetention = 0.9
     var defaultMaximumInterval = 36500.0
-    var defaultW = [
-      0.4072, 1.1829, 3.1262, 15.4722, 7.2102, 0.5316, 1.0651, 0.0234, 1.616,
-      0.1544, 1.0824, 1.9813, 0.0953, 0.2975, 2.2042, 0.2407, 2.9466, 0.5034,
-      0.6567,
-    ]
+    var defaultW = [0.4072, 1.1829, 3.1262, 15.4722, 7.2102, 0.5316, 1.0651, 0.0234, 1.616, 0.1544, 1.0824, 1.9813, 0.0953, 0.2975, 2.2042, 0.2407, 2.9466, 0.5034, 0.6567]
     var defaultEnableFuzz = false
     var defaultEnableShortTerm = true
 

diff --git a/Sources/FSRS/Models/FSRSModels.swift b/Sources/FSRS/Models/FSRSModels.swift
@@ -12,7 +12,7 @@ public enum CardState: Int, Codable {
       case review = 2
       case relearning = 3
 
-    var stringValue: String {
+    public var stringValue: String {
         switch self {
         case .new: return "new"
         case .learning: return "learning"
@@ -144,7 +144,7 @@ public struct Card: Equatable, Codable {
 }
 
 public struct RecordLogItem: Codable, Equatable {
-    var card: Card
+    public var card: Card
     var log: ReviewLog
 }
 
@@ -157,7 +157,7 @@ public struct FSRSParameters: Codable, Equatable {
     var enableFuzz: Bool
     var enableShortTerm: Bool
 
-    init(
+    public init(
         requestRetention: Double? = nil,
         maximumInterval: Double? = nil,
         w: [Double]? = nil,

diff --git a/Sources/FSRS/Models/FSRSTypes.swift b/Sources/FSRS/Models/FSRSTypes.swift
@@ -13,7 +13,7 @@ public struct IPreview {
         self.recordLog = recordLog
     }
 
-    subscript(rating: Rating) -> RecordLogItem? {
+    public subscript(rating: Rating) -> RecordLogItem? {
         get {
             recordLog[rating]
         }