Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine-tuned w1 and w2 #148

Merged
merged 2 commits into from
Jan 5, 2025
Merged

Conversation

Expertium
Copy link
Contributor

See #137 (comment)

Of course, I want you to implement this in the optimizer.

Copy link
Member

@L-M-Sherlock L-M-Sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will re-benchmark FSRS-5-pretrain tomorrow.

@L-M-Sherlock L-M-Sherlock merged commit e41b64b into open-spaced-repetition:main Jan 5, 2025
@Expertium
Copy link
Contributor Author

Expertium commented Jan 5, 2025

I don't think it will affect the metrics. Interpolation is needed only if a button or two have never been used during the first review. But if those buttons have never been used, that means their respective S0 will also never be used!
In other words, we cannot see any difference using our current benchmarking setup. But there will be a difference for those real users who have never used a button and are now starting to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants