-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest version is not working with sail enabled #34
Comments
Thanks for raising the issue! Will take a look at this |
+1 on this issue |
Sorry to say but this feature cannot be viable, as VSCode doesn't provide same Bash/Zsh/shell context with it so doesn't know where Docker is or any other binary, for global Pint this uses a predefined path setting, but Sail needs Docker therefore need to be on the PATH, the one we can't have access to from an child process from the VSCode one (unless some special things applied to this one). Anyway will continue on the research of this and add help wanted |
@d8vjork have you considered something like this? docker-compose exec -T laravel.test ./vendor/bin/pint This executes the command inside the default app container that comes with Sail and logs the output to terminal. Should be executable from the shell context of VSCode and its extensions (works fine for me locally anyway.) |
@jseitel Problem with that still the same, need to find out where is that |
@d8vjork I haven't looked into the details but it was working as expected with v0.7.3 and still is. What changed? |
You are actually right... after checking 0.7.x I discovered that I was actually wrapping the execution into a VSCode Task, will try if I could achieve the same on this new refactor I did on v1 Note to myself: Use |
Laravel pint vscode, still isn't working with docker/sail, is there any development on this ? Is there any workaround? |
use 0.7.3 |
I encountered a similar issue with the latest version of the Laravel Pint VSCode extension not working correctly in a Laravel Sail setup. After some troubleshooting, I found a solution that worked for me, especially if you're working in a My Solution:If you're using a "settings": {
"laravel-pint.enable": true,
"laravel-pint.executablePath": "vendor/laravel/pint/builds/pint",
"[php]": {
"editor.defaultFormatter": "open-southeners.laravel-pint",
"editor.formatOnSave": true
}
} The Problem:It seems that the default path for Laravel Pint ( Alternative Solution:If you're not using a I hope this helps anyone else encountering the same issue! |
Just to report, I have same issue! Waiting for new version, but using version 0.7.3 as commented above |
Describe the bug
The latest extension version is not working with Laravel Sail setting enabled. It seems to be ignored.
To Reproduce
Steps to reproduce the behavior:
enableDebugLogs: true
runInLaravelSail: true
Expected behavior
Using the sail path to run pint.
Environment:
enableDebugLogs: true, runInLaravelSail: true
Additional context
The version 0.7.3 works as expected.
The text was updated successfully, but these errors were encountered: