Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format on autosave not being applied #54

Closed
calebeso opened this issue Jan 9, 2024 · 3 comments
Closed

Format on autosave not being applied #54

calebeso opened this issue Jan 9, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@calebeso
Copy link

calebeso commented Jan 9, 2024

Describe the bug
The format on autosave mode its not being applied, even when Ctrl + Shift + P -> Format document using Laravel Pint

To Reproduce
1 - Install latest version of the extension
2 - Extension settings
3 - Check enabled - Check Log debug - Check Run in Laravel Sail

Expected behavior
To format the file when saved or using the Ctrl + Shift + P option...

Environment:

  • Operating system: Linux Ubuntu
  • IDE / version: VsCode 1.85.0
  • Extension version : latest
  • Extension's config:
 {
    "laravel-pint.enable": true,
    "laravel-pint.enableDebugLogs": true,
    "laravel-pint.fallbackToGlobalBin": false,
    "laravel-pint.runInLaravelSail": true
}

Additional context
When I run directly through the command line with ./vendor/bin/pint it just works fine!

@calebeso calebeso added the bug Something isn't working label Jan 9, 2024
@bmalen
Copy link

bmalen commented Jan 9, 2024

Also not working on Windows. Possibly the same issue as #52

@d8vjork
Copy link
Member

d8vjork commented Jan 11, 2024

This is because the Laravel Sail thing doesn't fully work. Related to #34

@d8vjork
Copy link
Member

d8vjork commented Jan 11, 2024

Closing because repeated issue, please track this on the other issue. If you think is not related go ahead and reopen this

@d8vjork d8vjork closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants