Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update customize_dataset.md - custom classes #861

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vavanade
Copy link

@vavanade vavanade commented Jun 1, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The currently described approach does not work on 1.x versions.

Modification

Update the document for the 1.x version.

@CLAassistant
Copy link

CLAassistant commented Jun 1, 2023

CLA assistant check
All committers have signed the CLA.

zytx121
zytx121 previously approved these changes Jun 8, 2023
Copy link
Collaborator

@zytx121 zytx121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RangiLyu RangiLyu changed the base branch from main to dev-1.x June 12, 2023 11:52
@RangiLyu RangiLyu dismissed zytx121’s stale review June 12, 2023 11:52

The base branch was changed.

@RangiLyu RangiLyu changed the base branch from dev-1.x to main June 12, 2023 11:52
@RangiLyu
Copy link
Member

Thanks for your contribution! If you want to update the document for the 1.x version, please rebase this PR to dev-1.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants